-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit p2p sync errors #2353
Audit p2p sync errors #2353
Conversation
fe3f4e4
to
ef8ad34
Compare
064c331
to
5f5ad9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another nit: the declaration of pathfinder_common::class_hash
in state_updates.rs
seems unused - not really part of error handling, but it is refactoring... :-)
Plus it needs to incorporate changes from #2349, naturally...
5f5ad9c
to
89f5b19
Compare
…mmitment missing are not fatal errors
Which have no associated peer.
f63cb16
to
b8e417c
Compare
Fixes: #2302
Some ideas from the issue ⬆️ were not implemented or a more convenient solution was chosen (for example: log errors at source in checkpoint sync, keep variants small, allow for implicit conversion from
anyhow::Error
because only one variant uses it).